feat: generate start and test npm scripts#387
Conversation
c6fd31d to
6ae5c5d
Compare
cexbrayat
left a comment
There was a problem hiding this comment.
Thanks for the PR @szgabsz91
I think you can do simpler than this, by just adding the script directly to the template/base/package.json for start. You can probably do the same for test with the template/**/package.json of each library, and that would avoid adding the addNpmScript function.
You can then generate the snapshots locally with pnpm snapshot and check if the result is OK.
|
Thanks for the quick review, @cexbrayat, I added a new commit with the modifications, keeping the old commit just for reference. (If the PR gets accepted in the future, a squash might be necessary.) Just some comments:
I don't know if the current solution is OK with you, but if not, I'll try to modify it later as you suggest. |
cexbrayat
left a comment
There was a problem hiding this comment.
I think I like this way better 👍
7c9431d to
8db43ce
Compare
|
@szgabsz91 Can you rebase the PR on the latest main branch, please? I'll then take a look. |
8db43ce to
0982194
Compare
|
I did the rebase yesterday, if I see it correctly, the branch is up to date with the remote main. I also resolved the conflicts around the nightwatch package.json files. |
cexbrayat
left a comment
There was a problem hiding this comment.
LGTM, thanks @szgabsz91
I'll let @sodatea take a look and merge if he feels this is interesting
|
Thanks! |
0982194 to
bf64fed
Compare
|
FYI: I just rebased the branch, now it's up-to-date again. :) |
| "type": "module", | ||
| "scripts": { | ||
| "dev": "vite", | ||
| "start": "npm run dev", |
There was a problem hiding this comment.
Here you may be able to dynamically obtain the corresponding script commands generated by the package manager.
Lines 569 to 576 in 9a4dd95
Resolves #303