Confine errgroup.Groups to scanDir in the Filesystem source#4808
Open
camgunz wants to merge 3 commits intofs-source-confine-symlink-state-to-scansymlinkfrom
Open
Confine errgroup.Groups to scanDir in the Filesystem source#4808camgunz wants to merge 3 commits intofs-source-confine-symlink-state-to-scansymlinkfrom
camgunz wants to merge 3 commits intofs-source-confine-symlink-state-to-scansymlinkfrom
Conversation
camgunz
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
camgunz
force-pushed
the
fs-source-simplify-workerpools
branch
from
dd9cca4 to
5c1131e
Compare
camgunz
force-pushed
the
fs-source-confine-symlink-state-to-scansymlink
branch
from
f8f26c1 to
940b4eb
Compare
camgunz
force-pushed
the
fs-source-simplify-workerpools
branch
from
5c1131e to
84bad12
Compare
camgunz
force-pushed
the
fs-source-confine-symlink-state-to-scansymlink
branch
from
940b4eb to
418d6cd
Compare
camgunz
force-pushed
the
fs-source-simplify-workerpools
branch
from
84bad12 to
f0fc20f
Compare
shahzadhaider1
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In the Filesystem source, only
scanDirutilizes anerrgroup.Group, so this simplifies things by only creating one there, rather than managing them throughout the rest of the source.