Confine symlink state handling to scanSymlink in Filesystem source#4807
Open
Confine symlink state handling to scanSymlink in Filesystem source#4807
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
shahzadhaider1
approved these changes
Mar 10, 2026
camgunz
force-pushed
the
fs-source-move-path-parameter
branch
from
5c710d2 to
c1bf617
Compare
camgunz
force-pushed
the
fs-source-confine-symlink-state-to-scansymlink
branch
from
f8f26c1 to
940b4eb
Compare
camgunz
force-pushed
the
fs-source-confine-symlink-state-to-scansymlink
branch
from
940b4eb to
418d6cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Tracking depth was scattered throughout the Filesystem source. This PR confines it to
scanSymlink, removing any responsibility from callers (and thus any potential for error).