Platform/RISC-V/RiscVPlatformSecLib: Link MemoryAllocationLib#953
Open
benjamindoron wants to merge 1 commit intotianocore:masterfrom
Open
Platform/RISC-V/RiscVPlatformSecLib: Link MemoryAllocationLib#953benjamindoron wants to merge 1 commit intotianocore:masterfrom
benjamindoron wants to merge 1 commit intotianocore:masterfrom
Conversation
As discovered on tianocore#909, this library uses MemoryAllocationLib without linking against it. This can succeed anyways, since SecCoreNative is this library's only consumer, and it takes the other library, but it's more proper to link against MemoryAllocationLib here too, and compilers will sometimes throw errors if not. Signed-off-by: Benjamin Doron <benjamin.doron@9elements.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered on #909, this library uses MemoryAllocationLib without linking against it.
This can succeed anyways, since SecCoreNative is this library's only consumer, and it takes the other library, but it's more proper to link against MemoryAllocationLib here too, and compilers will sometimes throw errors if not.