SG2042: Modify some files of SG2042#920
Open
DennisDing2003 wants to merge 8 commits intotianocore:masterfrom
Open
SG2042: Modify some files of SG2042#920DennisDing2003 wants to merge 8 commits intotianocore:masterfrom
DennisDing2003 wants to merge 8 commits intotianocore:masterfrom
Conversation
DennisDing2003
requested review from
leiflindholm,
mdkinney and
vlsunil
as code owners
vlsunil
reviewed
Dec 8, 2025
Contributor
vlsunil
left a comment
vlsunil
left a comment
There was a problem hiding this comment.
Thanks for the PR. Some high level feedback.
- Please update the PR and commit message as in EDK2 format(https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format). From the PR and commit message itself it should be clear which package/platform the patch is modifying. Ex: "Platform/ARM/VExpressPkg: Update size of virtio blk device".
- Commit message should describe the why the change is required and how. Just saying modify doesn't provide enough details to reviewers what exactly is changing and why.
- It is great that you are adding ACPI support as well!. However, have you looked at using DynamicTablesPkg which can be used to create most of the common ACPI tables from the DT. It will help in updating or moving to newer platforms.
- Please use ACPI 6.6 table versions (ex: in FADT) and run latest upstream FWTS on your platform since RISC-V support is added only in 6.6.
Author
|
Thank you for the detailed feedback. We agree that the third point regarding the DynamicTablesPkg is a valuable suggestion and we plan to explore it. And we will address the first two points by correcting the commit message format and providing the necessary details for the current changes. |
DennisDing2003
force-pushed
the
SG2042_Bootable_Fixed
branch
8 times, most recently
from
fb0f576 to
54b2705
Compare
Modify basic file for SG2042 to ensure successful compilation and boot. This change is required due to recent modifications in upstream EDK2 libraries. Cc: dahogn <dahogn@hotmail.com> Cc: meng-cz <mengcz1126@gmail.com> Cc: Jingyu Li <jingyu.li01@sophgo.com> Cc: Chao Wei <chao.wei@sophgo.com> Signed-off-by: ZixuanDing <dennisding2003@gmail.com> Co-authored-by: USER0FISH <libing1202@outlook.com>
Modify .dec files to support boot process of SG2042 Cc: dahogn <dahogn@hotmail.com> Cc: meng-cz <mengcz1126@gmail.com> Cc: Jingyu Li <jingyu.li01@sophgo.com> Cc: Chao Wei <chao.wei@sophgo.com> Signed-off-by: ZixuanDing <dennisding2003@gmail.com> Co-authored-by: USER0FISH <libing1202@outlook.com>
DennisDing2003
force-pushed
the
SG2042_Bootable_Fixed
branch
from
54b2705 to
4170d12
Compare
Updated SEC-phase files to align with library changes. This includes adaptations to the modified FDT-related functions and the removal of FirmwareContext in edk2. Cc: dahogn <dahogn@hotmail.com> Cc: meng-cz <mengcz1126@gmail.com> Cc: Jingyu Li <jingyu.li01@sophgo.com> Cc: Chao Wei <chao.wei@sophgo.com> Signed-off-by: ZixuanDing <dennisding2003@gmail.com> Co-authored-by: USER0FISH <libing1202@outlook.com>
DennisDing2003
force-pushed
the
SG2042_Bootable_Fixed
branch
from
4170d12 to
1551029
Compare
Modify SmbiosPlatformDxe.c since the version and structure of Smbios in edk2 are changed. Cc: dahogn <dahogn@hotmail.com> Cc: meng-cz <mengcz1126@gmail.com> Cc: Jingyu Li <jingyu.li01@sophgo.com> Cc: Chao Wei <chao.wei@sophgo.com> Signed-off-by: ZixuanDing <dennisding2003@gmail.com> Co-authored-by: USER0FISH <libing1202@outlook.com>
Add ACPI support to change boot mode from device tree to ACPI. Cc: dahogn <dahogn@hotmail.com> Cc: meng-cz <mengcz1126@gmail.com> Cc: Jingyu Li <jingyu.li01@sophgo.com> Cc: Chao Wei <chao.wei@sophgo.com> Signed-off-by: ZixuanDing <dennisding2003@gmail.com> Co-authored-by: USER0FISH <libing1202@outlook.com>
DennisDing2003
force-pushed
the
SG2042_Bootable_Fixed
branch
from
1551029 to
573a4a5
Compare
Add some device drivers of SG2042, enabling support for new hardware features. Cc: dahogn <dahogn@hotmail.com> Cc: meng-cz <mengcz1126@gmail.com> Cc: Jingyu Li <jingyu.li01@sophgo.com> Cc: Chao Wei <chao.wei@sophgo.com> Signed-off-by: ZixuanDing <dennisding2003@gmail.com> Co-authored-by: USER0FISH <libing1202@outlook.com>
Fix some bugs when compiling to support boot process of SG2042 Cc: dahogn <dahogn@hotmail.com> Cc: meng-cz <mengcz1126@gmail.com> Cc: Jingyu Li <jingyu.li01@sophgo.com> Cc: Chao Wei <chao.wei@sophgo.com> Signed-off-by: ZixuanDing <dennisding2003@gmail.com> Co-authored-by: USER0FISH <libing1202@outlook.com>
Fix a PCD to avoid compile error Cc: dahogn <dahogn@hotmail.com> Cc: meng-cz <mengcz1126@gmail.com> Cc: Jingyu Li <jingyu.li01@sophgo.com> Cc: Chao Wei <chao.wei@sophgo.com> Signed-off-by: ZixuanDing <dennisding2003@gmail.com> Co-authored-by: USER0FISH <libing1202@outlook.com>
DennisDing2003
force-pushed
the
SG2042_Bootable_Fixed
branch
from
573a4a5 to
1f56a31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated SG2042-related files to align with recent library changes in edk2.
Additionally, several drivers (including ACPI support) have been added.
The changes have been compiled and tested on SG2042 hardware, and the system now boots successfully.
Cc: dahogn dahogn@hotmail.com
Cc: meng-cz mengcz1126@gmail.com
Cc: Jingyu Li jingyu.li01@sophgo.com
Cc: Chao Wei chao.wei@sophgo.com
Signed-off-by: ZixuanDing dennisding2003@gmail.com
Co-authored-by: USER0FISH libing1202@outlook.com