Prefer semantic selectors over CSS-first recorder output#35
Open
michaelgichia wants to merge 1 commit intotesting-library:mainfrom
Open
Prefer semantic selectors over CSS-first recorder output#35michaelgichia wants to merge 1 commit intotesting-library:mainfrom
michaelgichia wants to merge 1 commit intotesting-library:mainfrom
Conversation
Author
|
@nickserv, kindly review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fix selector resolution in the Recorder -> Testing Library export so it no longer blindly uses
step.selectors[0](often CSS). The exporter now prefers semantic selector candidates and emits user-facing RTL queries when possible.Why:
Recorder exports currently produce brittle
document.querySelector(...)calls even when the same step includes richer selector candidates (aria/...,text/...). This goes against the React Testing Library principle of querying the UI the way users perceive it.Using your integration recordings, a step that includes
aria/Add API KEYwas exported as a CSS query, making tests implementation-detail driven and unstable.How:
changeclickhoverdoubleClickwaitForElementaria/...text/...aria/<name>[role="..."]role="generic"and falls back to inferred concrete roles in safe casesscreen.getByRole(role, {name})screen.getByText(name)fallbackdocument.querySelector(...)as last resort.Before / After from recordings:
Validation:
npm test -- --runInBand --watchman=false src/__tests__/Extension.tsVersioning:
Checklist: