Skip to content

fix(MNT-429): added theme variables to Tag field plugin#27

Merged
nathinho89 merged 15 commits intomainfrom
fix/MNT-429-tags-not-respecting-themes
Mar 5, 2026
Merged

fix(MNT-429): added theme variables to Tag field plugin#27
nathinho89 merged 15 commits intomainfrom
fix/MNT-429-tags-not-respecting-themes

Conversation

@nathinho89
Copy link
Contributor

@nathinho89 nathinho89 commented Mar 2, 2026

Jira Ticket:

https://storyblok.atlassian.net/browse/MNT-429

Description

This PR introduces the required theme variables for the dark and dark-high-contrast themes that are set in the Storyblok app.

Screenshots

Dark variables:
Screenshot 2026-03-04 at 16 28 55

Light variables:
Screenshot 2026-03-04 at 16 29 33

@cursor
Copy link

cursor bot commented Mar 2, 2026

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on April 1.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copy link
Collaborator

@demetriusfeijoo demetriusfeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nathinho89 🙌

The code looks good, but for some reason, it didn't work on the Visual Editor.

See:

Image

I guess it is because this plugin didn't have the theme attribute added to its HTML.

Image

Copy link
Collaborator

@demetriusfeijoo demetriusfeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nathinho89 🙌
Thanks for taking care of the theme handling. I have tested, and visually, it looks perfect both in the Field Plugin Editor and Visual Editor 🚀

I have left some suggestions, though, with small improvements, so we use the design tokens the most 🚀

Please, let me know what you think 🙏

I'm also wondering if it would be possible to not use !important in some places, but increase the selector specificity, maybe. Wdyt? 🤔

@nathinho89
Copy link
Contributor Author

Thanks @demetriusfeijoo - your comments have now been actioned 😄

Copy link
Collaborator

@demetriusfeijoo demetriusfeijoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @nathinho89 🚀 🚀

I think it is our first plugin using the design-tokens and handling properly different themes 😍 😍

Screen.Recording.2026-03-05.at.08.51.56.mov
Screen.Recording.2026-03-05.at.08.52.42.mov

@nathinho89 nathinho89 merged commit 3f143b2 into main Mar 5, 2026
6 checks passed
@nathinho89 nathinho89 deleted the fix/MNT-429-tags-not-respecting-themes branch March 5, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants