fix(MNT-429): added theme variables to Tag field plugin#27
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on April 1. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
demetriusfeijoo
left a comment
There was a problem hiding this comment.
Hey @nathinho89 🙌
The code looks good, but for some reason, it didn't work on the Visual Editor.
See:
I guess it is because this plugin didn't have the theme attribute added to its HTML.
demetriusfeijoo
left a comment
There was a problem hiding this comment.
Hey @nathinho89 🙌
Thanks for taking care of the theme handling. I have tested, and visually, it looks perfect both in the Field Plugin Editor and Visual Editor 🚀
I have left some suggestions, though, with small improvements, so we use the design tokens the most 🚀
Please, let me know what you think 🙏
I'm also wondering if it would be possible to not use !important in some places, but increase the selector specificity, maybe. Wdyt? 🤔
|
Thanks @demetriusfeijoo - your comments have now been actioned 😄 |
demetriusfeijoo
left a comment
There was a problem hiding this comment.
Nice job @nathinho89 🚀 🚀
I think it is our first plugin using the design-tokens and handling properly different themes 😍 😍
Jira Ticket:
https://storyblok.atlassian.net/browse/MNT-429
Description
This PR introduces the required theme variables for the dark and dark-high-contrast themes that are set in the Storyblok app.
Screenshots
Dark variables:

Light variables:
