Refactor the custom reporters for testing#20828
Refactor the custom reporters for testing#20828timvandermeij merged 3 commits intomozilla:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20828 +/- ##
==========================================
- Coverage 62.65% 62.62% -0.03%
==========================================
Files 169 169
Lines 120729 120729
==========================================
- Hits 75644 75612 -32
- Misses 45085 45117 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f733b4a99f88ef8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/5f06a06fc51a971/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f733b4a99f88ef8/output.txt Total script time: 43.62 mins
Image differences available at: http://54.241.84.105:8877/f733b4a99f88ef8/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5f06a06fc51a971/output.txt Total script time: 72.28 mins
Image differences available at: http://54.193.163.58:8877/5f06a06fc51a971/reftest-analyzer.html#web=eq.log |
This makes the order of checks consistent with the one in `test/reporter.js` and improves safety because now any status other than passed will be treated as a failure (also if Jasmine adds more statuses later on).
…rters This improves readability of the code and makes it consistent with the recently added check for excluded tests.
Similar to excluded tests pending tests should not count towards runs or result in console logging because they are effectively not (fully) run. This reduces visual noise and helps to get the tests running on GitHub Actions where non-passed tests will count towards a non-zero exit code.
timvandermeij
force-pushed
the
refactor-reporter
branch
from
8a22faa to
5fb9f12
Compare
4 participants
The commit messages contain more details about the individual changes.
Related to #11851.