feat: add per-file rule overrides to config#98
Open
MeinhartThomas wants to merge 1 commit intomillionco:mainfrom
Open
feat: add per-file rule overrides to config#98MeinhartThomas wants to merge 1 commit intomillionco:mainfrom
MeinhartThomas wants to merge 1 commit intomillionco:mainfrom
Conversation
Allow disabling specific rules for specific file patterns via a new `overrides` field in react-doctor.config.json, similar to ESLint overrides.
|
@MeinhartThomas is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
Comment on lines
+13
to
+14
| filePatterns: override.files.map(compileGlobPattern), | ||
| ignoredRules: new Set(override.ignore.rules), |
There was a problem hiding this comment.
Suggested change
| filePatterns: override.files.map(compileGlobPattern), | |
| ignoredRules: new Set(override.ignore.rules), | |
| filePatterns: Array.isArray(override.files) ? override.files.map(compileGlobPattern) : [], | |
| ignoredRules: new Set(Array.isArray(override.ignore?.rules) ? override.ignore.rules : []), |
The compileOverrides function crashes with "Cannot read properties of undefined" when processing malformed override configs missing ignore or files properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overridesfield toreact-doctor.config.jsonthat allows disabling specific rules for specific file patterns (similar to ESLint overrides)files(glob patterns) andignore.rules(rule identifiers to suppress for those files)ignore.rulesandignore.filesbehavior is unchangedExample config
{ "overrides": [ { "files": ["src/legacy/**", "src/generated/**"], "ignore": { "rules": ["react-doctor/no-giant-component", "react/no-danger"] } }, { "files": ["**/*.test.tsx"], "ignore": { "rules": ["knip/exports"] } } ] }Test plan
ignore.rulesandignore.filesMade with Cursor