Great Cancellation Finale: Tying Up Loose Ends#2005
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds cancellation token propagation to several async Azure SDK calls in the LoadTesting and Cosmos services that were previously missing cancellation support. This is part of a broader effort (titled "Great Cancellation Finale") to ensure cancellation tokens are consistently threaded through all async operations.
Changes:
- Passes
CancellationTokenviaRequestContextto Azure Load Testing SDK data-plane calls (GetTestRunAsync,BeginTestRunAsync,GetTestAsync,CreateOrUpdateTestAsync). - Adds
WaitAsync(cancellationToken)toCosmosClient.ReadAccountAsync()which lacks a native cancellation token overload. - Injects
IHostApplicationLifetimeintoCosmosServiceto replaceCancellationToken.NonewithApplicationStoppingin theDisposeAsyncCorecleanup method.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tools/Azure.Mcp.Tools.LoadTesting/src/Services/LoadTestingService.cs |
Adds RequestContext { CancellationToken = cancellationToken } to four data-plane SDK calls |
tools/Azure.Mcp.Tools.Cosmos/src/Services/CosmosService.cs |
Adds cancellation to ReadAccountAsync via WaitAsync, injects IHostApplicationLifetime for disposal cancellation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update CosmosService to use cancellationToken where not supported in method and use timeout for async calls in Dipose method
Update LoadTestingService to Pass in cancellationToken using RequestContext for AzureLoadTesting SDK calls
GitHub issue number?
#1583
#1767
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabel/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline