Correct the failure message when test is run on a wrong configuration#4322
Open
kanchansenlaskar wants to merge 1 commit intomainfrom
Open
Correct the failure message when test is run on a wrong configuration#4322kanchansenlaskar wants to merge 1 commit intomainfrom
kanchansenlaskar wants to merge 1 commit intomainfrom
Conversation
kanchansenlaskar
requested review from
LiliDeng and
johnsongeorge-w
as code owners
Collaborator
|
it contains the possibilities that quota is not enough |
johnsongeorge-w
requested changes
Mar 10, 2026
|
|
||
| if not found: | ||
| error = f"no available quota found on '{location}'." | ||
| error = "Test is run on a wrong configuration" |
Collaborator
There was a problem hiding this comment.
I agree, “no available quota” can be misleading at times. However, replacing it with “wrong configuration” also doesn’t help clarify whether the issue is due to a lack of available candidates, no matching VM sizes, or insufficient quota. Can we enhance the conditional block to perform these checks and surface a more specific error message?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing message which talks about unavailability of quota is a very misleading error message.
Tests get skipped with this error message when it is run on a wrong/unsupported configuration.