Skip to content

Fix immediate popup on start#231

Draft
rene-descartes2021 wants to merge 1 commit intoliuchengxu:masterfrom
rene-descartes2021:start-timout
Draft

Fix immediate popup on start#231
rene-descartes2021 wants to merge 1 commit intoliuchengxu:masterfrom
rene-descartes2021:start-timout

Conversation

@rene-descartes2021
Copy link
Collaborator

@rene-descartes2021 rene-descartes2021 commented Dec 6, 2022

Changes:

  • Fixed problem in which_key#start(). If description dictionary is small, then even if user types fast the window will show immediately, as getchar(1) is reached quickly and is false, then window shows.
    • A problem with this fix is if the dictionary is large, then the cumulative delay could be around 2 seconds... Could be mitigated with use of reltime(), if has('reltime').
    • Related: g:which_key_timeout doesn't seem to work #158. Perhaps there could be a boolean setting added here which allows the end-user to show the popup menu immediately without delay, if they wanted.

Stuff that will be in other PRs:

  • [WIP] Fix regression in :WhichKey! {dict} form? Cache shouldn't be shared between the two forms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant