Fix keycode merge bugs introduced with 9875baef#230
Open
rene-descartes2021 wants to merge 1 commit intoliuchengxu:masterfrom
Open
Fix keycode merge bugs introduced with 9875baef#230rene-descartes2021 wants to merge 1 commit intoliuchengxu:masterfrom
rene-descartes2021 wants to merge 1 commit intoliuchengxu:masterfrom
Conversation
a17b423 to
0cb742d
Compare
0cb742d to
a5e3cea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
<C-I>exists in the dict and<Tab>doesn't, it will error with E741 on the call toextend(). I'm puzzled why this didn't occur in my earlier testing.s:KEYCODESands:MERGE_INTO.deepcopy()call inwhich_key#start(), will handle registration with a nested dictionary now, e.g.which_key#register('z', 'g:my_map.z'). Not sure of use-case but it works now.nr2char()replaced withwhich_key#char_handler#parse_raw().