Fix conversation leakage in RemembersConversations::forUser()#260
Open
Button99 wants to merge 1 commit intolaravel:0.xfrom
Open
Fix conversation leakage in RemembersConversations::forUser()#260Button99 wants to merge 1 commit intolaravel:0.xfrom
Button99 wants to merge 1 commit intolaravel:0.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a security bug where reusing an agent instance across multiple users would leak conversation history between users.
This happens because the
forUser()method only updates the$conversationUserand does not reset the$conversationId. When the same agent instance is used for multiple users, the second user would continue 1st user's conversation, allowing access to private conversation history.The fix resets
$conversationIdto null inforUser()to ensure each user starts a new conversation.