[0.x] rename anonymous class helper methods to avoid Pint renaming#257
Open
jackbayliss wants to merge 2 commits intolaravel:0.xfrom
Open
[0.x] rename anonymous class helper methods to avoid Pint renaming#257jackbayliss wants to merge 2 commits intolaravel:0.xfrom
jackbayliss wants to merge 2 commits intolaravel:0.xfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, another PR!
Pint's
php_unit_method_casingrule was renaming one of the testInvokeTool anonymous class helper methods totest_invoke_tool, causing the test to fail when running locally. I assumed it was a typo in my previous PR, but its actually pint :DThis PR renames all three methods to callInvokeTool to prevent Pint from touching them which just prevents confusion for anyone testing unit tests locally.
TLDR - stops pint doing: