refactor: remove redundant Welcome nav and cleanup content#678
Open
TineoC wants to merge 1 commit intokubernetes:masterfrom
Open
refactor: remove redundant Welcome nav and cleanup content#678TineoC wants to merge 1 commit intokubernetes:masterfrom
TineoC wants to merge 1 commit intokubernetes:masterfrom
Conversation
This commit removes the Welcome navbar entry, deletes the redundant welcome content directory, and adds a redirect from /welcome to the root index.
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TineoC The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #629 was merged, the welcome page content has been promoted to the root index. This PR removes the redundant "Welcome" button from the navbar, cleans up the original /welcome content, and adds a permanent redirect from /welcome to the root to ensure any existing links still function correctly.
I also deleted the now-redundant content/en/welcome/ directory and its associated assets.