Decompile base & derived types in place#3081
Open
miloush wants to merge 1 commit intoicsharpcode:masterfrom
Open
Decompile base & derived types in place#3081miloush wants to merge 1 commit intoicsharpcode:masterfrom
miloush wants to merge 1 commit intoicsharpcode:masterfrom
Conversation
dgrunwald
reviewed
Nov 15, 2023
| App.Current.Dispatcher.Invoke(DispatcherPriority.Normal, new Action(EnsureLazyChildren)); | ||
| for (int i = 0; i < Children.Count; i++) | ||
| { | ||
| // LazyChildren are async and will not be ready on first call, avoid foreach. |
Member
There was a problem hiding this comment.
I don't see how avoiding foreach helps here, you still have a race condition.
421865a to
7902ca3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The list of base and derived types in ILSpy does not show anything useful in the output. At least assembly name and list of base types would be helpful, but I don't see any reason why the whole type, which already provides this information, cannot be decompiled in place - it is a simple change in the code and users do not have to jump back and forth when going through and comparing the implementations.
Solution
BaseTypesTreeNodeandDerivedTypesTreeNode) were calling all children to decompile. However, with increasing information in child nodes, it is not sustainable. They now explicitly list the children type names only, like they did before.