Skip to content

Add support for Fish Audio s2-pro model#165269

Merged
justanotherariel merged 1 commit intohome-assistant:devfrom
noambav:add-fish-s2-pro-model
Mar 11, 2026
Merged

Add support for Fish Audio s2-pro model#165269
justanotherariel merged 1 commit intohome-assistant:devfrom
noambav:add-fish-s2-pro-model

Conversation

@noambav
Copy link
Contributor

@noambav noambav commented Mar 10, 2026

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the Fish Audio s2-pro model to the Fish Audio TTS integration. It adds s2-pro as the first (and therefore default) backend model option, replacing s1 as the default for new TTS voice configurations.

Changes:

  • Added "s2-pro" to the beginning of the BACKEND_MODELS list in const.py
  • Updated the default backend model selection in the config flow schema from "s1" to "s2-pro"

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/fish_audio/const.py Added "s2-pro" as the first entry in BACKEND_MODELS
homeassistant/components/fish_audio/config_flow.py Updated default backend value from "s1" to "s2-pro" in get_model_selection_schema

Copy link
Member

@justanotherariel justanotherariel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I just checked again, and are you sure that upgrading the model like this is enough? Shouldn't the library be bumped to 1.3.0 too?

https://github.com/fishaudio/fish-audio-python/releases

@justanotherariel justanotherariel dismissed their stale review March 10, 2026 16:44

need clarification

@noambav
Copy link
Contributor Author

noambav commented Mar 11, 2026

I tested it on the 1.00 version and it worked (maybe there was a silent fallback).
But yea you are right we should bump it to 1.3.0 regardless but I am unable to test it right now to make sure nothing breaks if we do (though i highly doubt it will break).
It will take me a day or two to do that.

@justanotherariel
Copy link
Member

justanotherariel commented Mar 11, 2026

Ok, if you say it works we can merge right now and you can create a follow up PR which bumps the version.

@justanotherariel justanotherariel merged commit f1a1e28 into home-assistant:dev Mar 11, 2026
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants