Possible fix for incorrect info when shipping a project

[Eobam]

Still waiting for confirmation from AVD and others, but it seems that projects being updated should be when ft started, not if they were submitted to another Hack Club event. See the recent thread w/ me and Carlson in review-embassy for some context. Don't approve this until further confirmation, please. I'll put a comment or delete the PR when that is done.

[maxwofford]

We actually care about both cases! A project can only be submitted to the YSWS db from flavortown as a full project if it...

• starts during flavortown
• gets shipped during flavortown
• doesn't have any other time submitted to another ysws

in all other cases it's submitted as a project update, or a "slice" of a full project. we don't have any problems with that, but it's a requirement because the YSWS db needs to have a note in the description field saying "this is a project update that includes X/Y/Z things done"

[maxwofford]

To clarify too, imagine the following cases (which would be failure cases):

• someone works on a project for campfire. they work 20 hours. they open a listing on flavortown & submit it for 30 hours (the original 20 hours + 10 new hours of work). flavortown approves it and a 30 hour record is created. Now there are 50 hours of work recorded in the YSWS db, despite the hacker working 30 hours in total. This is fake time and makes Hack Club untrustworthy as an org if we publish "people spent X time learning".
• someone works on a project for high seas & it's in the YSWS db. The description is "I built ABC, a terminal emulator". They keep working on it and months later they submit to flavortown. This shows up as a second record & the description is "I built ABC, a terminal emulator". Now the YSWS db has 2 records that both have the same repo & play link with no explanation that they aren't an accidental duplicate. This looks like fraud or a bug (even though it isn't).

[dinosaur890123]

Yeah i thought that those were the reasons why it exists in the first place

[Eobam]

All makes sense! I think that the YSWS team and Fraud Squad (I presume, considering this relates to that) just need to decide on the exact wording. I just made this PR as after some talks, it seemed like the wording should've been broadened, and I decided to just put it here. Hopefully, this goes somewher,e and everything gets a bit clearer

[maxwofford]

if you make this an addition over a replacement i'm happy to accept the change! i like your wording for your change, it just needs to be in addition to the existing rule!

[dinosaur890123]

I was thinking that its better it stays as it is, as thats the whole purpose of the button to avoid confusion on double universal ysws entries

[3kh0]

Stale + conflicts present