Skip to content

fix(deps): update github.com/grafana/dskit digest to 6415010 (main)#14601

Open
renovate-sh-app[bot] wants to merge 1 commit intomainfrom
deps-update/main-github.com-grafana-dskit-digest
Open

fix(deps): update github.com/grafana/dskit digest to 6415010 (main)#14601
renovate-sh-app[bot] wants to merge 1 commit intomainfrom
deps-update/main-github.com-grafana-dskit-digest

Conversation

@renovate-sh-app
Copy link
Contributor

@renovate-sh-app renovate-sh-app bot commented Mar 9, 2026

This PR contains the following updates:

Package Type Update Change
github.com/grafana/dskit require digest 49ab18c6415010

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 04:59 AM, only on Monday ( * 0-4 * * 1 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Need help?

You can ask for more help in the following Slack channel: #proj-renovate-self-hosted. In that channel you can also find ADR and FAQ docs in the Resources section.

@renovate-sh-app renovate-sh-app bot requested a review from stevesg as a code owner March 9, 2026 02:07
@renovate-sh-app renovate-sh-app bot requested a review from a team as a code owner March 9, 2026 02:07
@renovate-sh-app
Copy link
Contributor Author

renovate-sh-app bot commented Mar 9, 2026

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 20 additional dependencies were updated

Details:

Package Change
google.golang.org/grpc v1.79.1 -> v1.79.2
github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.7 -> v2.28.0
go.opentelemetry.io/contrib/bridges/prometheus v0.65.0 -> v0.66.0
go.opentelemetry.io/contrib/exporters/autoexport v0.65.0 -> v0.66.0
go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace v0.65.0 -> v0.66.0
go.opentelemetry.io/contrib/samplers/jaegerremote v0.34.0 -> v0.35.0
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.16.0 -> v0.17.0
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.16.0 -> v0.17.0
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.40.0 -> v1.41.0
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.40.0 -> v1.41.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.40.0 -> v1.41.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.40.0 -> v1.41.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.40.0 -> v1.41.0
go.opentelemetry.io/otel/exporters/prometheus v0.62.0 -> v0.63.0
go.opentelemetry.io/otel/exporters/stdout/stdoutlog v0.16.0 -> v0.17.0
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.40.0 -> v1.41.0
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.40.0 -> v1.41.0
go.opentelemetry.io/otel/log v0.16.0 -> v0.17.0
go.opentelemetry.io/otel/sdk/log v0.16.0 -> v0.17.0
github.com/hashicorp/consul/api v1.33.2 -> v1.33.4

@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-dskit-digest branch from 4e7724d to 114d091 Compare March 9, 2026 11:05
@renovate-sh-app renovate-sh-app bot changed the title fix(deps): update github.com/grafana/dskit digest to 8c00e18 (main) fix(deps): update github.com/grafana/dskit digest to 6415010 (main) Mar 9, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Duration metric loses error attributes when export metric disabled
    • Adjusted ExportOp.End to compute error attribute options whenever either exported-spans or duration metrics are enabled, so duration records retain error.type even when exported-spans is disabled.

Create PR

Or push these changes by commenting:

@cursor push bea453220f
Preview (bea453220f)
diff --git a/vendor/go.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/observ/instrumentation.go b/vendor/go.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/observ/instrumentation.go
--- a/vendor/go.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/observ/instrumentation.go
+++ b/vendor/go.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/observ/instrumentation.go
@@ -204,7 +204,7 @@
 	}
 
 	mOpt := e.inst.setOpt
-	if err != nil && exportedSpansEnable {
+	if err != nil && (exportedSpansEnable || opDurationEnable) {
 		attrs := get[attribute.KeyValue](measureAttrsPool)
 		defer put(measureAttrsPool, attrs)
 		*attrs = append(*attrs, e.inst.attrs...)
@@ -215,10 +215,11 @@
 		set := attribute.NewSet(*attrs...)
 		mOpt = metric.WithAttributeSet(set)
 
-		// Reset addOpt with new attribute set.
-		*addOpt = append((*addOpt)[:0], mOpt)
-
-		e.inst.exportedSpans.Add(e.ctx, e.nSpans-success, *addOpt...)
+		if exportedSpansEnable {
+			// Reset addOpt with new attribute set.
+			*addOpt = append((*addOpt)[:0], mOpt)
+			e.inst.exportedSpans.Add(e.ctx, e.nSpans-success, *addOpt...)
+		}
 	}
 
 	if opDurationEnable {

recordOpt := get[metric.RecordOption](recordOptPool)
defer put(recordOptPool, recordOpt)
*recordOpt = append(*recordOpt, mOpt)
e.inst.opDuration.Record(e.ctx, time.Since(e.start).Seconds(), *recordOpt...)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duration metric loses error attributes when export metric disabled

Low Severity

In ExportOp.End, mOpt only gets error-type attributes when exportedSpansEnable is true (line 207). The opDuration metric at line 227 uses this same mOpt, so when err != nil and exportedSpansEnable is false but opDurationEnable is true, the duration metric is recorded without the error.type attribute. The sibling implementations (stdoutmetric, otlptracegrpc, otlptracehttp) all correctly compute error attributes for the duration metric independently of the exported-spans metric's enabled state.

Fix in Cursor Fix in Web

@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-dskit-digest branch from 114d091 to 1697c0c Compare March 9, 2026 14:07
Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
@renovate-sh-app renovate-sh-app bot force-pushed the deps-update/main-github.com-grafana-dskit-digest branch from 1697c0c to 799ad0c Compare March 10, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants