fix(deps): update github.com/grafana/dskit digest to 6415010 (main)#14601
fix(deps): update github.com/grafana/dskit digest to 6415010 (main)#14601renovate-sh-app[bot] wants to merge 1 commit intomainfrom
Conversation
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
4e7724d to
114d091
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Duration metric loses error attributes when export metric disabled
- Adjusted ExportOp.End to compute error attribute options whenever either exported-spans or duration metrics are enabled, so duration records retain error.type even when exported-spans is disabled.
Or push these changes by commenting:
@cursor push bea453220f
Preview (bea453220f)
diff --git a/vendor/go.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/observ/instrumentation.go b/vendor/go.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/observ/instrumentation.go
--- a/vendor/go.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/observ/instrumentation.go
+++ b/vendor/go.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/observ/instrumentation.go
@@ -204,7 +204,7 @@
}
mOpt := e.inst.setOpt
- if err != nil && exportedSpansEnable {
+ if err != nil && (exportedSpansEnable || opDurationEnable) {
attrs := get[attribute.KeyValue](measureAttrsPool)
defer put(measureAttrsPool, attrs)
*attrs = append(*attrs, e.inst.attrs...)
@@ -215,10 +215,11 @@
set := attribute.NewSet(*attrs...)
mOpt = metric.WithAttributeSet(set)
- // Reset addOpt with new attribute set.
- *addOpt = append((*addOpt)[:0], mOpt)
-
- e.inst.exportedSpans.Add(e.ctx, e.nSpans-success, *addOpt...)
+ if exportedSpansEnable {
+ // Reset addOpt with new attribute set.
+ *addOpt = append((*addOpt)[:0], mOpt)
+ e.inst.exportedSpans.Add(e.ctx, e.nSpans-success, *addOpt...)
+ }
}
if opDurationEnable {| recordOpt := get[metric.RecordOption](recordOptPool) | ||
| defer put(recordOptPool, recordOpt) | ||
| *recordOpt = append(*recordOpt, mOpt) | ||
| e.inst.opDuration.Record(e.ctx, time.Since(e.start).Seconds(), *recordOpt...) |
There was a problem hiding this comment.
Duration metric loses error attributes when export metric disabled
Low Severity
In ExportOp.End, mOpt only gets error-type attributes when exportedSpansEnable is true (line 207). The opDuration metric at line 227 uses this same mOpt, so when err != nil and exportedSpansEnable is false but opDurationEnable is true, the duration metric is recorded without the error.type attribute. The sibling implementations (stdoutmetric, otlptracegrpc, otlptracehttp) all correctly compute error attributes for the duration metric independently of the exported-spans metric's enabled state.
114d091 to
1697c0c
Compare
Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
1697c0c to
799ad0c
Compare



This PR contains the following updates:
49ab18c→6415010Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 04:59 AM, only on Monday ( * 0-4 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
Need help?
You can ask for more help in the following Slack channel: #proj-renovate-self-hosted. In that channel you can also find ADR and FAQ docs in the Resources section.