Skip to content

Temporarily skips tests that assign Copilot and timeout too early#155

Merged
lindseywild merged 7 commits intomainfrom
lw/skip-copilot-creation-tests
Mar 10, 2026
Merged

Temporarily skips tests that assign Copilot and timeout too early#155
lindseywild merged 7 commits intomainfrom
lw/skip-copilot-creation-tests

Conversation

@lindseywild
Copy link
Contributor

@lindseywild lindseywild commented Mar 10, 2026

Temporarily skips tests that were failing because Copilot isn't creating the PRs in time, and the linked PRs are not returning before the timeout. We will add more thorough integration tests as a follow up.

@lindseywild lindseywild changed the title Skips flaky copilot-related tests Addresses tests that assign Copilot and timeout too early Mar 10, 2026
@lindseywild lindseywild marked this pull request as ready for review March 10, 2026 14:24
@lindseywild lindseywild requested a review from a team as a code owner March 10, 2026 14:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the retry behavior used by the .github/actions/fix GitHub Action, increasing how long it will wait while polling for a linked pull request after assigning an issue.

Changes:

  • Increase the default maxAttempts in retry() from 6 to 10 (extends total exponential backoff time).
Comments suppressed due to low confidence (1)

.github/actions/fix/src/retry.ts:19

  • Increasing the default maxAttempts to 10 increases worst-case wait time substantially due to the 30s cap (roughly ~3 minutes total backoff vs ~1 minute previously, plus fn runtime). Since callers like fix/src/index.ts don't pass an explicit maxAttempts, this will lengthen GitHub Action runtimes per issue and can amplify timeouts when multiple issues are processed; consider keeping the default lower and passing a higher value only where needed, or making maxAttempts/time budget configurable via action input.
  maxAttempts = 10,

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lindseywild lindseywild changed the title Addresses tests that assign Copilot and timeout too early Temporarily skips tests that assign Copilot and timeout too early Mar 10, 2026
@github github deleted a comment from Copilot AI Mar 10, 2026
@lindseywild lindseywild enabled auto-merge March 10, 2026 14:55
@lindseywild lindseywild merged commit 9c3f4a5 into main Mar 10, 2026
6 checks passed
@lindseywild lindseywild deleted the lw/skip-copilot-creation-tests branch March 10, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants