Skip to content

built-in themes#2191

Draft
azizmejri1 wants to merge 1 commit intodyad-sh:mainfrom
azizmejri1:built-in-theme
Draft

built-in themes#2191
azizmejri1 wants to merge 1 commit intodyad-sh:mainfrom
azizmejri1:built-in-theme

Conversation

@azizmejri1
Copy link
Collaborator

@azizmejri1 azizmejri1 commented Jan 15, 2026

Summary by cubic

Added a built-in Apple (Cupertino) theme and exposed it in the theme menu with an Apple icon. This enables a consistent iOS/macOS look via semantic tokens and clear UI rules.

  • New Features
    • New β€œApple Theme” in themesData with CSS variables, dark-mode tokens, and component patterns (buttons, lists, search).
    • AuxiliaryActionsMenu shows the Apple icon for this theme and supports selecting it.

Written for commit 4626172. Summary will update on new commits.


Note

Adds a new built-in apple theme alongside the default theme.

  • Defines APPLE_THEME_PROMPT with detailed Cupertino design rules in shared/themes.ts and registers it in themesData
  • Updates AuxiliaryActionsMenu.tsx to import Apple icon and display it for themes with icon === "apple"

Written by Cursor Bugbot for commit 4626172. This will update automatically on new commits. Configure here.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @azizmejri1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's theming capabilities by introducing a new 'Apple Theme'. This theme provides a robust and detailed set of design guidelines and semantic tokens, enabling the application to adopt the distinctive Cupertino aesthetic. This addition offers users greater customization options and ensures a consistent, high-quality user interface experience aligned with Apple's design language.

Highlights

  • New Apple Theme Introduced: A comprehensive 'Apple Theme' has been added, providing detailed guidelines for recreating the Cupertino design aesthetic, including semantic tokens, CSS variables, and specific design rules for UI components.
  • Apple Icon Integration: The Apple icon from lucide-react is now imported and conditionally rendered within the AuxiliaryActionsMenu component, appearing when the 'Apple Theme' is selected.
  • Detailed Design System Guidelines: The new theme prompt includes extensive instructions covering colors, typography, borders, corner smoothing (squircle effect), and depth effects (blur + shadow) to ensure accurate replication of the iOS/macOS look and feel.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@wwwillchen
Copy link
Collaborator

@BugBot run

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new built-in 'Apple' theme. The changes include adding the theme definition and prompt in src/shared/themes.ts, and updating src/components/chat/AuxiliaryActionsMenu.tsx to display the new theme option with its corresponding icon. The implementation is straightforward. I've added one suggestion to refactor the icon rendering logic for better maintainability and to reduce code duplication.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Bugbot reviewed your changes and found no bugs!

@github-actions
Copy link
Contributor

🎭 Playwright Test Results

❌ Some tests failed

OS Passed Failed Flaky Skipped
🍎 macOS 201 2 1 79
πŸͺŸ Windows 202 0 2 79

Summary: 403 passed, 2 failed, 3 flaky, 158 skipped

Failed Tests

🍎 macOS

  • context_window.spec.ts > context window
    • Error: expect(string).toMatchSnapshot(expected) failed
  • turbo_edits_v2.spec.ts > turbo edits v2 - search-replace approve
    • Error: expect(string).toMatchSnapshot(expected) failed

⚠️ Flaky Tests

🍎 macOS

  • setup.spec.ts > setup ai provider (passed after 1 retry)

πŸͺŸ Windows

  • security_review.spec.ts > security review - multi-select and fix issues (passed after 1 retry)
  • setup.spec.ts > setup ai provider (passed after 1 retry)

πŸ“Š View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants