Skip to content

cli/command: add missing "go:build" comments#6854

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:missing_buildtags
Mar 10, 2026
Merged

cli/command: add missing "go:build" comments#6854
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:missing_buildtags

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 10, 2026

cli/command: add missing "go:build" comments

  • commit e8dc2fc modernized loops to range over int, which requires go1.22 or later.
  • commit 85ebca5 modernized code to use stdlib min/max, which requires go1.21 or later.

- Human readable description for the release notes

Go SDK: Add missing build-tag, which could cause `cannot range over 10 (untyped int constant)`  when importing the `cli/command` package.

- A picture of a cute animal (not mandatory but encouraged)

- commit e8dc2fc modernized loops to
  range over int, which requires go1.22 or later.
- commit 85ebca5 modernized code to
  use stdlib min/max, which requires go1.21 or later.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 29.3.1 milestone Mar 10, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah added impact/changelog area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Mar 10, 2026
@thaJeztah thaJeztah merged commit 5d8cc2c into docker:master Mar 10, 2026
127 of 132 checks passed
@thaJeztah thaJeztah deleted the missing_buildtags branch March 10, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK impact/changelog impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/bugfix PR's that fix bugs status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot range over 10 in v29.3.0+incompatible

3 participants