Add validity bounds to the TzOffset API and support for iteration over TzOffsets#199
Open
gharveymn wants to merge 1 commit intochronotope:mainfrom
Open
Add validity bounds to the TzOffset API and support for iteration over TzOffsets#199gharveymn wants to merge 1 commit intochronotope:mainfrom
TzOffset API and support for iteration over TzOffsets#199gharveymn wants to merge 1 commit intochronotope:mainfrom
Conversation
Also, add support for iteration over `TzOffset`s.
djc
reviewed
Jun 13, 2025
Member
djc
left a comment
There was a problem hiding this comment.
I think this is too invasive for a niche use case.
Is there API we could offer that would allow you to implement this outside this crate?
Contributor
|
I think this is a useful API, I was looking for something like it as well. Getting the next transition is a common TZDB API: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: Certain event driven programs require scheduling based on changes to the offset which is active for a given timezone.
The changes here essentially turn
TzOffsetinto a cursor over the offsets for a given timezone.