feat: swap 404 page H1 to show username availability as primary heading#28347
Draft
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Draft
feat: swap 404 page H1 to show username availability as primary heading#28347devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: susan <susan@cal.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Swaps the copy hierarchy on the 404 page so that the username availability message ("The username X is still available. Register now.") is promoted to the
<h1>heading, and "This page does not exist." becomes the smaller subtext below it.Before:
After:
The
isSubpagecase (including "Booking not found") is left unchanged — only the primary 404 page layout is affected.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
cal.com/nonexistent-user-abc123)cal.com/some-user/some-event) to confirm that case still shows "This page does not exist." as the H1 with "check spelling" subtext.Human Review Checklist
<a>nested inside the<h1>(IS_CALCOM branch) renders and behaves correctly — link should still be clickable and styledisSubpage/ booking-not-found case is visually unaffectedChecklist