fix: resolve invalid DOM nesting in DataTable SeparatorRowRenderer#28293
Draft
dougwithseismic wants to merge 2 commits intocalcom:mainfrom
Draft
fix: resolve invalid DOM nesting in DataTable SeparatorRowRenderer#28293dougwithseismic wants to merge 2 commits intocalcom:mainfrom
dougwithseismic wants to merge 2 commits intocalcom:mainfrom
Conversation
…alcom#28184) Replace <div> with <TableCell colSpan={...}> inside <TableRow> to fix invalid DOM nesting (div cannot be a child of tr). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #28184
The
SeparatorRowRendererin the DataTable component rendered a<div>directly inside a<TableRow>(<tr>), which is invalid HTML — a<tr>can only contain<td>or<th>elements. This caused React hydration warnings and accessibility issues.Changes
<div>with<TableCell>inSeparatorRowRenderercolSpanprop to span all table columnstable.getAllColumns().lengthas thecolSpanvalue at the call siteHow should this be tested?
<tr><td colspan="N">...</td></tr>instead of<tr><div>...</div></tr>Mandatory Tasks
🤖 Generated with Claude Code