Fix relative settings file resolution when merging sandbox config#663
Open
shuofengzhang wants to merge 1 commit intoanthropics:mainfrom
Open
Fix relative settings file resolution when merging sandbox config#663shuofengzhang wants to merge 1 commit intoanthropics:mainfrom
shuofengzhang wants to merge 1 commit intoanthropics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
settingsfile paths againstcwdwhen sandbox settings are merged inSubprocessCLITransport._resolve_settings_path()helper to centralize settings path resolution.settings="settings.json"+cwd=<dir>+sandbox=...correctly loads and merges the settings file.Why
When
sandboxis provided, the SDK parses settings files itself before passing merged JSON to the CLI. Previously, relativesettingspaths were resolved from the process working directory instead ofcwd, which could cause the SDK to miss valid settings files and drop existing settings unexpectedly.Testing
pytest -q