fix(opencode): log tool execution error stack traces#16935
Open
jpcarranza94 wants to merge 2 commits intoanomalyco:devfrom
Open
fix(opencode): log tool execution error stack traces#16935jpcarranza94 wants to merge 2 commits intoanomalyco:devfrom
jpcarranza94 wants to merge 2 commits intoanomalyco:devfrom
Conversation
Fixes anomalyco#16925 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
The e2e (linux) failure is unrelated to this change — it's a flaky Playwright test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16925
Type of change
What does this PR do?
When a tool throws during execution, the
tool-errorhandler inprocessor.tsconverts the error to a string via.toString(), which discards the stack trace. Nolog.error()is emitted either, so the error is invisible in server logs — even at--log-level DEBUG.This adds a single
log.error()call before the existing.toString()conversion. The stack trace appears in the logs, existing behavior is unchanged.How did you verify your code works?
Ran
opencode serve --log-level DEBUGunder sustained load (~800 sessions/hour). Before this change, tool errors likeRangeError: Maximum call stack size exceededonly appeared embedded insideservice=llmlog entries. After this change, they show as standaloneERRORentries with full stack traces.Screenshots / recordings
N/A — server-side logging change, no UI impact.
Checklist