fix(core): implement proper workspace routing for session routes#16930
Open
fix(core): implement proper workspace routing for session routes#16930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we only used
x-opencode-workspacebut we will want to get rid of that once we have syncing. At that point, we will want to forward only certain routes to a workspace based on information from the URL. This implements simple routing to do that for the session routes; there are more routes in the future we will route too.Basically, the server provides a unified set of routes, but we are "taking over" a subset of those routes and automatically forwarding them to workspace. For example, if you call the endpoint to delete message in the session, that should route to the workspace which will do that, and then the syncing mechanism will sync that mutation back to anywhere else it needs to go.