refactor(project): load icons from .opencode assets#16929
Draft
anduimagui wants to merge 5 commits intoanomalyco:devfrom
Draft
refactor(project): load icons from .opencode assets#16929anduimagui wants to merge 5 commits intoanomalyco:devfrom
anduimagui wants to merge 5 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
The new resolution behavior prioritizes icon files inside
.opencode/icon/first, then falls back to.opencode/**/favicon.*, and then keeps discovery fallback for repository favicon files. It also adds support for.urlfiles (direct URL/data URL orURL=...format).The motivation is to make icon setup easier and repo-centric: teams can drop icon files into
.opencodeand have predictable loading without wiring paths in config. This should make it simpler to bootstrap repos with default branding/assets. I am still open to discussion on long-term config direction and how this should coexist withopencode.jsonas those formats are still being iterated.How did you verify your code works?
packages/opencode/test/project/project.test.tsfor.opencodeicon priority behavior.iconinopencode.json.bun test test/project/project.test.ts test/config/config.test.ts(frompackages/opencode)Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.