Remove verify_prism_regression_tests.sh#826
Open
thomasmarshall wants to merge 1 commit intomasterfrom
Open
Conversation
amomchilov
force-pushed
the
desugar-remaining
branch
2 times, most recently
from
d96acf3 to
7f35d5d
Compare
thomasmarshall
force-pushed
the
remove-verify-prism-script
branch
from
9491219 to
e4f28a9
Compare
amomchilov
force-pushed
the
desugar-remaining
branch
from
7f35d5d to
14a6ede
Compare
thomasmarshall
force-pushed
the
remove-verify-prism-script
branch
from
e4f28a9 to
b8e2118
Compare
We no longer need this script. The `prism_regression` tests themselves compare the desugar tree with the original parser. We no longer have parse trees to compare, because we're directly desugaring from Prism nodes to AST expression pointers.
thomasmarshall
force-pushed
the
remove-verify-prism-script
branch
from
b8e2118 to
dc32032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need this script. The
prism_regressiontests themselves compare the desugar tree with the original parser. We no longer have parse trees to compare, because we're directly desugaring from Prism nodes to AST expression pointers.