Skip to content

Remove preserveConcreteSyntax parameter from Prism translate #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jesse-shopify wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove preserveConcreteSyntax parameter from Prism translate #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parser/prism/Translator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ unique_ptr<parser::Node> Translator::translateSendAssignment(pm_node_t *node, co
move(lhs));
}

unique_ptr<parser::Node> Translator::translate(pm_node_t *node, bool preserveConcreteSyntax) {
unique_ptr<parser::Node> Translator::translate(pm_node_t *node) {
if (node == nullptr)
return nullptr;

Expand Down
2 changes: 1 addition & 1 deletion parser/prism/Translator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class Translator final {
desugarUniqueCounter(this->desugarUniqueCounterStorage) {}

// Translates the given AST from Prism's node types into the equivalent AST in Sorbet's legacy parser node types.
std::unique_ptr<parser::Node> translate(pm_node_t *node, bool preserveConcreteSyntax = false);
std::unique_ptr<parser::Node> translate(pm_node_t *node);

private:
// This private constructor is used for creating child translators with modified context.
Expand Down
Loading