Open
Conversation
… correct average that is used.
…zeroes it, and the last thread copies it.
threads are not responsive for stat collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix statistics with shared memory. The total was added by the threads and thus the partial total is exposed while the threads add up. The thread 0 wipes the total, but is not guaranteed to be the first, so the total contains stats from different time periods. The fix is there to stop that.
The mesh_time_median stat value is fixed to add up to the correct average that is used, as well.
The stat interval is selected so that threads have stat timer callbacks at the same time. The threads use the same time offset in the interval for that.
The stat totals are collected together in a separate struct. When it is done, the struct with totals is copied into the shared memory area.
Fixes #152 . Since the totals are added together properly before the copy to the shared memory. If some threads are not responding, the total does not get updated during that time, but gets updated afterwards.