Overload local_data_remove to support removing specific records#1087
Open
rcmcdonald91 wants to merge 1 commit intoNLnetLabs:masterfrom
Open
Overload local_data_remove to support removing specific records#1087rcmcdonald91 wants to merge 1 commit intoNLnetLabs:masterfrom
local_data_remove to support removing specific records#1087rcmcdonald91 wants to merge 1 commit intoNLnetLabs:masterfrom
Conversation
Here we overload the `local_data_remove` control command to support deleting specific records. Curently, this command deletes all records for a given zone. The modification works by attempting to parse the command argument first as a complete record and then as just a domain name, if the first attempt failed. This preserves the command's behavior, while also supporting removing specific records from the zone tree. Signed-off-by: R. Christian McDonald <rcm@rcm.sh>
Contributor
Author
|
@wcawijngaards can I get some eyes on this? Thanks! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we overload the
local_data_removecontrol command to support deleting specific records. Curently, this command deletes all records for a given zone. The modification works by attempting to parse the command argument first as a complete record and then as just a domain name, if the first attempt failed.This preserves the command's behavior, while also supporting removing specific records from the zone tree.