Conversation
Collaborator
What about GAP_pkg_juliainterface? Doesn't that show up in some stacktraces? |
Member
Author
|
True, but so far it wasn't problematic. Even if it is, it can be rebuilt separately later on. This change here is the big one (for macOS; on Linux things are already in a good shape) |
lgoettgens
approved these changes
Mar 11, 2026
Collaborator
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
Seems reasonable, but I haven't tested it locally
Collaborator
|
Would it make sense to bump the version number, so you can require a newer version in you dev branch of GAP.jl? |
Member
Author
|
good point, will do |
This allows Base.stacktrace() from inside GAP to traverse back into Julia code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows Base.stacktrace() from inside GAP to traverse back into Julia code. This will allow us to produce much more helpful backtraces in GAP.jl.
Note that GAP does not link against the C++ standard library, does not use C++ exceptions, or expose or consume any C++ ABIs. So I think this should be fine without applying a similar treatment to GAP packages which use C++, such as semigroups or normalizinterface.