option to give usage_example in AutoBuild#645
Open
aminya wants to merge 1 commit intoJuliaPackaging:masterfrom
aminya:readme
Open
option to give usage_example in AutoBuild#645aminya wants to merge 1 commit intoJuliaPackaging:masterfrom aminya:readme
aminya wants to merge 1 commit intoJuliaPackaging:masterfrom
aminya:readme
Conversation
aminya
changed the title
fingolfin
reviewed
Jul 11, 2020
src/AutoBuild.jl
Outdated
Comment on lines
+261
to
+262
| extract_kwargs(kwargs, (:lazy_artifacts,))..., | ||
| extract_kwargs(kwargs, (:usage_example,))..., |
Member
There was a problem hiding this comment.
Perhaps this would be better?
Suggested change
| extract_kwargs(kwargs, (:lazy_artifacts,))..., | |
| extract_kwargs(kwargs, (:usage_example,))..., | |
| extract_kwargs(kwargs, (:lazy_artifacts, :usage_example))..., |
fingolfin
reviewed
Jul 11, 2020
| gh_org::String = "JuliaBinaryWrappers", | ||
| code_dir::String = joinpath(Pkg.devdir(), "$(name)_jll"), | ||
| verbose::Bool = false, lazy_artifacts::Bool = false) | ||
| verbose::Bool = false, lazy_artifacts::Bool = false, usage_example::String = default_usage_example) |
Member
There was a problem hiding this comment.
I am afraid this needs rebasing now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.