Skip to content

Fix: not rendering declined requests on google calendar#1271

Open
interfinityOfficial wants to merge 3 commits intomainfrom
1230-not-rendering-declined-google-calendar-events
Open

Fix: not rendering declined requests on google calendar#1271
interfinityOfficial wants to merge 3 commits intomainfrom
1230-not-rendering-declined-google-calendar-events

Conversation

@interfinityOfficial
Copy link
Collaborator

Summary of Changes

DECLINED events were being hidden on the calendar because DECLINED was in CALENDAR_HIDE_STATUS. It was removed from that list in components/src/policy.ts so DECLINED events show on the calendar and are included in overlap checks, avoiding double bookings.

Checklist

  • I checked for existing implementations and confirmed there is no duplication
  • I thoroughly tested this feature locally
  • I added or updated unit tests (or explained why not in the PR description)
  • I attached screenshots or a video demonstrating the feature
  • I incorporated Copilot's feedback (or explained why not in the PR description), and marked conversation as resolved
  • I confirmed my PR passed all unit and end-to-end (E2E) tests
  • I confirmed there are no conflicts
  • I requested a code review from at least one other teammate

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes DECLINED from the set of booking statuses that are hidden in calendar views so declined requests render on the Google Calendar UI and are considered during overlap detection.

Changes:

  • Removed BookingStatusLabel.DECLINED from CALENDAR_HIDE_STATUS.
  • Added a unit test ensuring DECLINED is not hidden while other hidden statuses remain unchanged.

Reviewed changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated no comments.

File Description
booking-app/components/src/policy.ts Updates CALENDAR_HIDE_STATUS to no longer hide declined events.
booking-app/tests/unit/policy.unit.test.ts Adds coverage to prevent regressions in which declined events are re-hidden.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rlho
Copy link
Collaborator

rlho commented Mar 9, 2026

@interfinityOfficial
It looks like there are unnecessary files included. Please only include the files that were changed in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: The Booking App calendar page is not rendering Google Calendar events with status = DECLINED which may lead to double bookings.

3 participants