Fix: not rendering declined requests on google calendar#1271
Open
interfinityOfficial wants to merge 3 commits intomainfrom
Open
Fix: not rendering declined requests on google calendar#1271interfinityOfficial wants to merge 3 commits intomainfrom
interfinityOfficial wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes DECLINED from the set of booking statuses that are hidden in calendar views so declined requests render on the Google Calendar UI and are considered during overlap detection.
Changes:
- Removed
BookingStatusLabel.DECLINEDfromCALENDAR_HIDE_STATUS. - Added a unit test ensuring
DECLINEDis not hidden while other hidden statuses remain unchanged.
Reviewed changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| booking-app/components/src/policy.ts | Updates CALENDAR_HIDE_STATUS to no longer hide declined events. |
| booking-app/tests/unit/policy.unit.test.ts | Adds coverage to prevent regressions in which declined events are re-hidden. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@interfinityOfficial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
DECLINED events were being hidden on the calendar because DECLINED was in CALENDAR_HIDE_STATUS. It was removed from that list in components/src/policy.ts so DECLINED events show on the calendar and are included in overlap checks, avoiding double bookings.
Checklist