Skip to content

fix: clean up install warnings#370

Open
alexx-ftw wants to merge 3 commits intoComposioHQ:mainfrom
alexx-ftw:fix/install-warning-cleanup
Open

fix: clean up install warnings#370
alexx-ftw wants to merge 3 commits intoComposioHQ:mainfrom
alexx-ftw:fix/install-warning-cleanup

Conversation

@alexx-ftw
Copy link

Summary

  • remove the repo-owned install/build warnings by marking runtime-only plugin imports as external
  • migrate the web terminal from deprecated xterm to @xterm/xterm and align Vitest/jsdom dependencies
  • switch the optional Composio notifier peer to @composio/core, update tests, and document the remaining upstream node-gyp deprecation

Verification

  • pnpm --filter @composio/ao-plugin-notifier-composio test
  • pnpm --filter @composio/ao-web build
  • pnpm --filter @composio/ao-web test src/__tests__/services.test.ts src/components/__tests__/DirectTerminal.test.ts
  • pnpm --filter @composio/ao-cli test -- dashboard
  • bash scripts/setup.sh

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9d71e3def2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@alexx-ftw
Copy link
Author

Addressed the review feedback in 6cb21d3:

  • restored legacy _clientOverride.executeAction compatibility for notifier overrides
  • removed the invalid Vitest 4 minWorkers setting
  • folded the remaining #350 Next.js Link and timer-cleanup changes into this PR

Verification rerun:

  • pnpm --filter @composio/ao-plugin-notifier-composio test
  • pnpm --filter @composio/ao-plugin-notifier-composio build
  • pnpm --filter @composio/ao-integration-tests exec vitest run src/notifier-composio.integration.test.ts
  • pnpm --filter @composio/ao-web build
  • pnpm --filter @composio/ao-cli test -- dashboard.test.ts

@alexx-ftw
Copy link
Author

Addressed the review feedback in :\n- restored legacy compatibility for notifier overrides\n- removed the invalid Vitest 4 setting\n- folded the remaining Next.js and timer-cleanup changes into this PR\n\nVerification rerun:\n-

@composio/ao-plugin-notifier-composio@0.1.0 test /home/eros/Desktop/agent-orchestrator/packages/plugins/notifier-composio
vitest run

RUN v4.0.18 /home/eros/Desktop/agent-orchestrator/packages/plugins/notifier-composio

✓ dist/index.test.js (29 tests) 14ms
✓ src/index.test.ts (29 tests) 14ms

Test Files 2 passed (2)
Tests 58 passed (58)
Start at 16:28:23
Duration 179ms (transform 109ms, setup 0ms, import 141ms, tests 28ms, environment 0ms)\n-

@composio/ao-plugin-notifier-composio@0.1.0 build /home/eros/Desktop/agent-orchestrator/packages/plugins/notifier-composio
tsc\n-
RUN v4.0.18 /home/eros/Desktop/agent-orchestrator/packages/integration-tests

✓ src/notifier-composio.integration.test.ts (10 tests) 9ms

Test Files 1 passed (1)
Tests 10 passed (10)
Start at 16:28:26
Duration 149ms (transform 36ms, setup 0ms, import 48ms, tests 9ms, environment 0ms)\n-

@composio/ao-web@0.1.0 build /home/eros/Desktop/agent-orchestrator/packages/web
next build

▲ Next.js 15.5.12

Creating an optimized production build ...
✓ Compiled successfully in 1767ms
Linting and checking validity of types ...
Collecting page data ...
Generating static pages (0/8) ...
Generating static pages (2/8)
Generating static pages (4/8)
Generating static pages (6/8)
✓ Generating static pages (8/8)
Finalizing page optimization ...
Collecting build traces ...

Route (app) Size First Load JS
┌ ƒ / 8.12 kB 110 kB
├ ○ /_not-found 992 B 103 kB
├ ƒ /api/events 147 B 102 kB
├ ƒ /api/prs/[id]/merge 147 B 102 kB
├ ƒ /api/sessions 147 B 102 kB
├ ƒ /api/sessions/[id] 147 B 102 kB
├ ƒ /api/sessions/[id]/kill 147 B 102 kB
├ ƒ /api/sessions/[id]/message 147 B 102 kB
├ ƒ /api/sessions/[id]/remap 147 B 102 kB
├ ƒ /api/sessions/[id]/restore 147 B 102 kB
├ ƒ /api/sessions/[id]/send 147 B 102 kB
├ ƒ /api/spawn 147 B 102 kB
├ ○ /dev/terminal-test 5.96 kB 112 kB
├ ○ /icon 147 B 102 kB
├ ƒ /sessions/[id] 10.6 kB 117 kB
└ ○ /test-direct 1.32 kB 107 kB

  • First Load JS shared by all 102 kB
    ├ chunks/597-ee3d6e72f75a78ef.js 45.8 kB
    ├ chunks/a51c26f2-7912c8e37f20294d.js 54.2 kB
    └ other shared chunks (total) 2.04 kB

○ (Static) prerendered as static content
ƒ (Dynamic) server-rendered on demand\n-

@composio/ao-cli@0.1.0 test /home/eros/Desktop/agent-orchestrator/packages/cli
vitest run "dashboard.test.ts"

RUN v4.0.18 /home/eros/Desktop/agent-orchestrator/packages/cli

tests/commands/dashboard.test.ts (14 tests) 20ms

Test Files 1 passed (1)
Tests 14 passed (14)
Start at 16:28:40
Duration 159ms (transform 43ms, setup 0ms, import 47ms, tests 20ms, environment 0ms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant