Sync Metrics Keys causes a glyph's info panel to reflect incorrect values

[xotypeco]

in my Glyphs 3.0.5 (3124), the first move of a point reliably fails to reflect its correct value in the info panel, but second move always reflects accurately.

less reliably: switching to another glyph leaves the wrong info window will be active (see screenshot).

I uninstalled and reinstalled every extension one-by-one. the culprit was “Sync Metrics Keys." not sure why. this isn't specific to this version of glyphs; I’ve been seeing it for the last few cutting edge versions.

[kontur]

Thanks for reporting this issue. I see same behaviour, here simply with changing the sidebearings, not with moving nodes — I suspect this is the same problem.

Screen.Recording.2022-04-21.at.10.38.32_.mov

@schriftgestalt 1. has there been a change to GSlayer.metricsKeyOutOfSync used here

glyphs-plugin-sync-metrics-keys/SyncMetricsKeys.glyphsPlugin/Contents/Resources/plugin.py

Line 203 in 0b62094

if l.metricsKeysOutOfSync() == 1 and self.layerHasContent(layer):

— I cannot actually find this method mentioned anywhere in the API or forums. When I log all layers' results in that piece of code it never returns any out of sync. 2. Even when I omit that check and just brute-force sync all layers in this callback (probably not advisable for performance) the behaviour is as in the screencap. The metrics do not update to the linked glyph, the update in numeric value only when switching to that glyph, and finally only another subsequent interaction (call to the same sync logic, I think) will trigger the actual UI update. Any ideas?

[schriftgestalt]

I didn’t look at the code but I suspect that there is a call to layer.beginChanges() and a layer.endChanges() is missing. It might be in the plugin code or a combination of API calls that leaves the layer in the disabled update state.

[kontur]

Okay, so you are saying the beingChanges() and endChanges() are mandatory?

It works better with this code:

@objc.python_method
    def syncAll(self):
        for g in Glyphs.font.glyphs:
            for l in g.layers:
                l.beginChanges()
                if l.metricsKeysOutOfSync() == 1 and self.layerHasContent(l):
                    self.log("Layer was out of sync, update linked metrics %s" % str(l))
                    l.syncMetrics()
                l.endChanges()

but I still get a problem with the last update not propagating in the editor until that glyph becomes active, see the last click into the "I" which only updates the metrics rendered (although the glyph already has the correct metric value propagated):

Screen.Recording.2022-04-21.at.13.22.39_.mov

Is there some kind of "update view" method I could call to re-render the editor?

[schriftgestalt]

Not mandatory but they always need to come in pairs. So make sure that you ALWAY call endChanges() if you have called beginChange().
When you need a "update view", you have messed up the begin/end calls. Because when you change anything on the active layer, it will trigger a redraw.

edit: Only if you change something on a not active layer, you may need to force a redraw:

Glyphs.redraw()

But don’t call that too often as it is expensive.

[xotypeco]

Thanks for reporting this issue. I see same behaviour, here simply with changing the sidebearings, not with moving nodes — I suspect this is the same problem.

just to chime in: I saw this as well, but figured I was messing up my sidebearings on my own (I'm finishing a project). the error with the plugin didn't become apparent until I spotted it while moving nodes.

[kontur]

@xotypeco Sorry to hear this is interfering with production work, that's of course the worst situation :/

@schriftgestalt 1) I didn't have any calls to beginChange in the entire plugin code. I've added begin and end calls now, just because it seems a good idea otherwise. 2) Even with the Glyphs.redraw() call it appears that the "last" update never propagates to the editor. Or put another way, once you activate the supposedly synced glyph it only then updates the editor view. See this screencap, the glyph with the linked sidebearing updates the metric value, but the visual editor representation "lags one update behind". The logs show the value of the original glyph (e.g. H with 62) is read correctly, there are logs that the UI redraws, and yet, the screencap shows that it only updates once you pop the cursor into the supposedly updated glyph. Code I took this screencap with is linked above.

Screen.Recording.2022-04-22.at.9.40.06.mov

[schriftgestalt]

I’ll have a look at the code.

[kontur]

@schriftgestalt did you have a chance to take a look at what causes this "delay" in updating the view?

[kontur]

I updated the code in master with those small improvements so far, but the above updating issue remains; the editor view is still always "one update" behind the actual value of the synced sidebearing. @schriftgestalt could you have a look, please?