File provider extension does not propagate remote folder deletion

[Floweb05]

⚠️ Before submitting, please verify the following: ⚠️

• This is a bug, not a question or a configuration issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
• I agree to follow Nextcloud's Code of Conduct

Bug description

Nextcloud MacOS client (VFS) don't delete folders after Server-side deletion.

Desktop log files:

Debug-LogNextcloudAPP.zip

Steps to reproduce

• On web Interface I have "Folder 1 > Subfolder > image.jpg".
• I travel that directory, locally, on Mac (virtual files).
• I delete "Folder 1" from the web interface.
• "Folder 1" is still shown locally on my Mac, with subfolder and (most of the time) it's content.

Expected behavior

A directory deleted on web-interface, should be deleted from local Sync.

Which files are affected by this bug

Seems any directory is concerned

Operating system

macOS

Which version of the operating system you are running.

23.6 + 15.7.4

Package

Official macOS Virtual files 12+ universal pkg

Nextcloud Server version

32.0.5

Nextcloud Desktop Client version

4.0.6 - 33.0.0-RC2

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

• Default internal user-backend
• LDAP/ Active Directory
• SSO - SAML
• Other

Nextcloud Server logs

No events recorded during the test.

Additional info

• Nextcloud Desktop APP show the "folder deleted" event, in the notification window (see screenshot)
• It's not linked to shared folder, or chars on Folder's names, or long directory paths.
• Occur 100% of the time. Only directories previously locally traveled.
• Disabling/Enabling Virtual Files is the only way to get the correct list folders/files displayed.
• If I delete a folder with multiple subfolders, some subfolders do get deleted, but some keep listed
• This bug don't occur with 3.16.6 VFS
• Server: Docker community official (not AIO) / Push notifications OK / Behind a Nginx proxy manager

I can provide more details if requested.
Can also provide a VNC access to a testing MAC, the same I Use.

[i2h3]

I assume that there must be something wrong in the synchronization logic then. With 33.0.0, the file provider extension should definitely at least know about the remote changes. I definitely need logs for this one to know what the file provider extension is doing. Maybe it also just fails to report it correctly to macOS while having it updated correctly in its own metadata.

I need to clarify how to safely collect logs from the community without leaking personal information to the public or malicious code injection.

[Floweb05]

@i2h3

the file provider extension should definitely at least know about the remote changes

I can see it partially remove folder content. It's like something prevent it to continue at some point.
(If I delete a folder with multiple subfolders, some subfolders do get deleted, but some keep listed)

I definitely need logs for this one

I posted logs zip (Bug description section), including Client debuglog + MacOS console events recorded during the test.
Tell me if you need something else.

I need to clarify how to safely collect logs from the community without leaking personal information to the public or malicious code injection.

I redacted it, I hope i didnt missed something 😶

Thanks

[i2h3]

@Floweb05 Ah, oops, I missed that debug archive. 🤪 Thanks! I will check it.

[i2h3]

I had a look into it and figured that the logs are insufficient to understand what is happening. I need to add further logging statements to our code. This is tricky, though, because those are often called code points and logging there might blow up the log sizes significantly.