Remove serial console log collection for network failure

Author: adityagesh

lisa/node.py

@@ -694,29 +694,9 @@ def _initialize(self, *args: Any, **kwargs: Any) -> None:
         try:
             super()._initialize(*args, **kwargs)
         except TcpConnectionException as e:
-            from lisa.features.run_command import RunCommand
-
-            run_command = self.features[RunCommand]
-            commands = [
-                "echo 'Executing: ip addr show'",
-                "ip addr show",
-                "echo 'Executing: ip link show'",
-                "ip link show",
-                "echo 'Executing: systemctl status NetworkManager --no-pager --plain'",
-                "systemctl status NetworkManager --no-pager --plain",
-                "echo 'Executing: systemctl status network --no-pager --plain'",
-                "systemctl status network --no-pager --plain",
-                "echo 'Executing: systemctl status systemd-networkd --no-pager --plain'",
-                "systemctl status systemd-networkd --no-pager --plain",
-                "echo 'Executing: ping -c 3 -n 8.8.8.8'",
-                "ping -c 3 -n 8.8.8.8",
-            ]
-            out = run_command.execute(commands=commands)
-            self.log.info(f"Collected information using run_command:\n{out}")
-            self._login_to_serial_console()
-            output = self._collect_info_using_serial_console(commands=commands)
-            self.log.info(f"Collected information using serial console:\n{output}")
-
+            vm_logs = self._collect_logs_using_platform()
+            if vm_logs:
+                self.log.info(f"Collected information using platform:\n{vm_logs}")
             raise e
 
     def get_working_path(self) -> PurePath:
@@ -761,6 +741,33 @@ def check_sudo_password_required(self) -> None:
                     raise RequireUserPasswordException("Reset password failed")
             self._check_password_and_store_prompt()
 
+    def _collect_logs_using_platform(self) -> Optional[str]:
+        """
+        Collects information using the RunCommand feature.
+        This is used when the connection to the node is not stable.
+        """
+        from lisa.features import RunCommand
+
+        if self.features.is_supported(RunCommand):
+            run_command = self.features[RunCommand]
+            commands = [
+                "echo 'Executing: ip addr show'",
+                "ip addr show",
+                "echo 'Executing: ip link show'",
+                "ip link show",
+                "echo 'Executing: systemctl status NetworkManager --no-pager --plain'",
+                "systemctl status NetworkManager --no-pager --plain",
+                "echo 'Executing: systemctl status network --no-pager --plain'",
+                "systemctl status network --no-pager --plain",
+                "echo 'Executing: systemctl status systemd-networkd --no-pager --plain'",
+                "systemctl status systemd-networkd --no-pager --plain",
+                "echo 'Executing: ping -c 3 -n 8.8.8.8'",
+                "ping -c 3 -n 8.8.8.8",
+            ]
+            out = run_command.execute(commands=commands)
+            return out
+        return None
+
     def _check_password_and_store_prompt(self) -> None:
         # self.shell.is_sudo_required_password is true, so running sudo command
         # will input password in process.wait_result. Check running sudo again
@@ -830,32 +837,6 @@ def _login_to_serial_console(self) -> None:
                     "No login prompt found, serial console is already logged in."
                 )
 
-    def _collect_info_using_serial_console(self, commands: List[str]) -> str:
-        from lisa.features import SerialConsole
-
-        if self.features.is_supported(SerialConsole):
-            serial_console = self.features[SerialConsole]
-            # clear the serial console
-            _ = serial_console.read()
-            commands = [
-                f"echo 'Executing: {cmd}' && {cmd}"
-                for cmd in [
-                    "ip addr show",
-                    "ip link show",
-                    "systemctl status NetworkManager --no-pager --plain",
-                    "systemctl status network --no-pager --plain",
-                    "systemctl status systemd-networkd --no-pager --plain",
-                    "ping -c 3 -n 8.8.8.8",
-                ]
-            ]
-            serial_console.write(data=commands)
-            output = serial_console.read()
-            return output
-        else:
-            raise LisaException(
-                "SerialConsole feature is not supported, cannot collect information."
-            )
-
     def _get_password(self, generate: bool = True) -> str:
         """
         Get the password for the node. If the password is not set, it will

lisa/sut_orchestrator/azure/features.py

@@ -333,12 +333,9 @@ def create_setting(
         return schema.FeatureSettings.create(cls.name())
 
     @retry(tries=3, delay=5)
-    def write(self, data: str | List[str]) -> None:
+    def write(self, data: str) -> None:
         # websocket connection is not stable, so we need to retry
         try:
-            if isinstance(data, list):
-                # if data is a list, join it with \n and add a newline to the last item
-                data = "\n".join(data) + "\n"
             self._write(data)
             return
         except websockets.ConnectionClosed as e:  # type: ignore