Skip to content

Commit 9028450

Browse files
Copilotpelikhan
andauthored
Fix __GH_AW_WIKI_NOTE__ placeholder not substituted when wiki is disabled (#20236)
* Initial plan * Fix __GH_AW_WIKI_NOTE__ placeholder not substituted when wiki is disabled When wiki mode is disabled (memory.Wiki == false), the GH_AW_WIKI_NOTE env var now uses ${{ '' }} (a GitHub expression evaluating to empty string) instead of a plain static empty string. This forces expression interpolation, ensuring the __GH_AW_WIKI_NOTE__ placeholder in repo_memory_prompt.md is always substituted with an empty value. Previously, old compiled lock files might not include GH_AW_WIKI_NOTE in the substitution step at all, causing the validate_prompt_placeholders.sh check to fail. Fixes: repo-assist __GH_AW_WIKI_NOTE__ placeholder not substituted when Wiki is disabled. Recompile all 166 workflow lock files to apply the fix. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Apply PR review suggestions: add constant and clarify comment - Add package-level constant `ghaEmptyStringExpr` for `${{ '' }}` and use it in both the production code and the test. - Reword the comment to clarify the expression ensures substitution in newly compiled (or regenerated) workflows by forcing the prompt- creation step to include GH_AW_WIKI_NOTE. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>
1 parent 81e2556 commit 9028450

24 files changed

+43
-6
lines changed

.changeset/patch-wiki-note-empty-placeholder.md

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/agent-performance-analyzer.lock.yml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/audit-workflows.lock.yml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/copilot-agent-analysis.lock.yml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/copilot-cli-deep-research.lock.yml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/copilot-pr-nlp-analysis.lock.yml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/copilot-pr-prompt-analysis.lock.yml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/copilot-session-insights.lock.yml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/daily-architecture-diagram.lock.yml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/daily-cli-performance.lock.yml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)