-
-
Notifications
You must be signed in to change notification settings - Fork 38
Open
Description
Currently, ROARR_LOG is not respected while running Jest tests as Jest runner mocks window object while running tests. While any console.log within jest can be turned off with --silent there's no way to prevent logs generated by roarr.
Suggestion:
Update createLogger conditional check with...
if (
typeof process !== 'undefined' && (
!isBrowser() // Not running in a browser
|| process.env.JEST_WORKER_ID !== undefined // Running in Jest test environment
|| process.env.SOME_OTHER_ID !== undefined // Running in other test environment
)
) { ... }
...to allow ROARR_LOG to be respected across test environments that are mocking window.
Ref: https://jestjs.io/docs/environment-variables
Ways to get around this is to downgrade from 7.21.0 (7.5.0 worked as it uses isNodeEnvironment check. Haven't tested all versions in between) or to override ROARR.write in jest node environment (not recommended)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels